Skip to content

Commit

Permalink
Remove deprecated ThreadNotification (#2051)
Browse files Browse the repository at this point in the history
  • Loading branch information
pepone authored Apr 16, 2024
1 parent 428bc35 commit 275afff
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 51 deletions.
11 changes: 0 additions & 11 deletions csharp/src/Ice/Instance.cs
Original file line number Diff line number Diff line change
Expand Up @@ -999,17 +999,6 @@ internal void initialize(Ice.Communicator communicator, Ice.InitializationData i
{
AssemblyUtil.preloadAssemblies();
}

#pragma warning disable 618
if (_initData.threadStart == null && _initData.threadHook != null)
{
_initData.threadStart = _initData.threadHook.start;
}
if (_initData.threadStop == null && _initData.threadHook != null)
{
_initData.threadStop = _initData.threadHook.stop;
}
#pragma warning restore 618
}
catch (Ice.LocalException)
{
Expand Down
12 changes: 0 additions & 12 deletions csharp/src/Ice/ThreadHookPlugin.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,6 @@ namespace Ice;
/// </summary>
public class ThreadHookPlugin : Plugin
{
/// <summary>
/// Installs a thread hook for a communicator.
/// </summary>
/// <param name="communicator">The communicator using the thread notification hook.</param>
/// <param name="threadHook">The thread notification hook for the communicator.</param>
[Obsolete("This constructor is deprecated. Use the constructor with threadStart and threadStop parameters instead.")]
public
ThreadHookPlugin(Communicator communicator, ThreadNotification threadHook) :
this(communicator, threadHook.start, threadHook.stop)
{
}

/// <summary>
/// Installs thread hooks for a communicator.
/// </summary>
Expand Down
28 changes: 0 additions & 28 deletions csharp/src/Ice/Util.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,28 +6,6 @@

namespace Ice
{
/// <summary>
/// Interface for thread notification hooks. Applications can derive
/// a class tat implements the start and stop
/// methods to intercept creation and destruction of threads created
/// by the Ice run time.
/// </summary>
public interface ThreadNotification
{
/// <summary>
/// The Ice run time calls start for each new
/// thread it creates. The call is made by the newly-started thread.
/// </summary>
void start();

/// <summary>
/// The Ice run time calls stop before it destroys
/// a thread. The call is made by thread that is about to be
/// destroyed.
/// </summary>
void stop();
}

/// <summary>
/// A class that encapsulates data to initialize a communicator.
/// </summary>
Expand Down Expand Up @@ -59,12 +37,6 @@ public object Clone()
/// </summary>
public Instrumentation.CommunicatorObserver observer;

/// <summary>
/// The thread hook for the communicator.
/// </summary>
[Obsolete("This data member is deprecated. Use threadStart or threadStop instead.")]
public ThreadNotification threadHook;

/// <summary>
/// The thread start hook for the communicator. The Ice run time
/// calls this hook for each new thread it creates. The call is
Expand Down

0 comments on commit 275afff

Please sign in to comment.