Enable DataStorm multicast testing on macOS

zeroc-ice · Oct 22, 2024 · afcdcf2 · afcdcf2
1 parent b533584
commit afcdcf2
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 50 deletions.
diff --git a/cpp/test/DataStorm/callbacks/test.py b/cpp/test/DataStorm/callbacks/test.py
@@ -2,7 +2,6 @@
 # Copyright (c) ZeroC, Inc. All rights reserved.
 #
 
-import sys
 from DataStormUtil import Reader, Writer
 from Util import ClientServerTestCase, TestSuite
 
@@ -22,14 +21,12 @@
         traceProps=traceProps),
 ]
 
-# TODO - enable once we figure out https://github.com/zeroc-ice/ice/issues/2929
-if sys.platform != "darwin":
-    test_cases.append(
-        ClientServerTestCase(
-            name = "Writer/Reader multicast enabled",
-            client = Writer(props = multicastProps),
-            server = Reader(props = multicastProps),
-            traceProps=traceProps),
-    )
+test_cases.append(
+    ClientServerTestCase(
+        name = "Writer/Reader multicast enabled",
+        client = Writer(props = multicastProps),
+        server = Reader(props = multicastProps),
+        traceProps=traceProps),
+)
 
 TestSuite(__file__, test_cases)
diff --git a/cpp/test/DataStorm/config/test.py b/cpp/test/DataStorm/config/test.py
@@ -4,7 +4,6 @@
 
 from DataStormUtil import Reader, Writer
 from Util import ClientServerTestCase, TestSuite
-import sys
 
 traceProps = {
     "DataStorm.Trace.Topic" : 1,
@@ -22,14 +21,12 @@
         traceProps=traceProps),
 ]
 
-# TODO - enable once we figure out https://github.com/zeroc-ice/ice/issues/2929
-if sys.platform != "darwin":
-    test_cases.append(
-        ClientServerTestCase(
-            name = "Writer/Reader multicast enabled",
-            client = Writer(props = multicastProps),
-            server = Reader(props = multicastProps),
-            traceProps=traceProps),
-    )
+test_cases.append(
+    ClientServerTestCase(
+        name = "Writer/Reader multicast enabled",
+        client = Writer(props = multicastProps),
+        server = Reader(props = multicastProps),
+        traceProps=traceProps),
+)
 
 TestSuite(__file__, test_cases)
diff --git a/cpp/test/DataStorm/events/test.py b/cpp/test/DataStorm/events/test.py
@@ -4,7 +4,6 @@
 
 from DataStormUtil import Reader, Writer
 from Util import ClientServerTestCase, TestSuite
-import sys
 
 traceProps = {
     "DataStorm.Trace.Topic" : 1,
@@ -24,14 +23,12 @@
         traceProps=traceProps),
 ]
 
-# TODO - enable once we figure out https://github.com/zeroc-ice/ice/issues/2929
-if sys.platform != "darwin":
-    test_cases.append(
-        ClientServerTestCase(
-            name = "Writer/Reader multicast enabled",
-            client = Writer(props = multicastProps),
-            server = Reader(props = multicastProps),
-            traceProps=traceProps),
-    )
+test_cases.append(
+    ClientServerTestCase(
+        name = "Writer/Reader multicast enabled",
+        client = Writer(props = multicastProps),
+        server = Reader(props = multicastProps),
+        traceProps=traceProps),
+)
 
 TestSuite(__file__, test_cases)
diff --git a/cpp/test/DataStorm/partial/test.py b/cpp/test/DataStorm/partial/test.py
@@ -4,7 +4,6 @@
 
 from DataStormUtil import Reader, Writer
 from Util import ClientServerTestCase, TestSuite
-import sys
 
 traceProps = {
     "DataStorm.Trace.Topic" : 1,
@@ -22,14 +21,12 @@
         traceProps=traceProps),
 ]
 
-# TODO - enable once we figure out https://github.com/zeroc-ice/ice/issues/2929
-if sys.platform != "darwin":
-    test_cases.append(
-        ClientServerTestCase(
-            name = "Writer/Reader multicast enabled",
-            client = Writer(props = multicastProps),
-            server = Reader(props = multicastProps),
-            traceProps=traceProps),
-    )
+test_cases.append(
+    ClientServerTestCase(
+        name = "Writer/Reader multicast enabled",
+        client = Writer(props = multicastProps),
+        server = Reader(props = multicastProps),
+        traceProps=traceProps),
+)
 
 TestSuite(__file__, test_cases)
diff --git a/cpp/test/DataStorm/types/test.py b/cpp/test/DataStorm/types/test.py
@@ -4,7 +4,6 @@
 
 from DataStormUtil import Reader, Writer
 from Util import ClientServerTestCase, TestSuite
-import sys
 
 traceProps = {
     "DataStorm.Trace.Topic" : 1,
@@ -22,14 +21,12 @@
         traceProps=traceProps),
 ]
 
-# TODO - enable once we figure out https://github.com/zeroc-ice/ice/issues/2929
-if sys.platform != "darwin":
-    test_cases.append(
-        ClientServerTestCase(
-            name = "Writer/Reader multicast enabled",
-            client = Writer(props = multicastProps),
-            server = Reader(props = multicastProps),
-            traceProps=traceProps),
-    )
+test_cases.append(
+    ClientServerTestCase(
+        name = "Writer/Reader multicast enabled",
+        client = Writer(props = multicastProps),
+        server = Reader(props = multicastProps),
+        traceProps=traceProps),
+)
 
 TestSuite(__file__, test_cases)