Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python install warnings #1545

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Fix Python install warnings #1545

merged 5 commits into from
Oct 11, 2023

Conversation

pepone
Copy link
Member

@pepone pepone commented Oct 11, 2023

See #1492

@pepone
Fix Cleanup of IceStorm DB Files
0ebacbb 
The 'dbbir' variable was only initialized when 'createDb' is set to true. This resulted in
files being left behind in the IceStorm/persistence test when using two instances, as
shown in the following code snippet:

```python
icestorm1 = IceStorm(createDb=True, cleanDb=False)
icestorm2 = IceStorm(createDb=False, cleanDb=True)
```
@pepone
Fix python install warnings
94a299e
@pepone pepone requested a review from externl October 11, 2023 14:08
externl
externl approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@externl externl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pepone pepone merged commit d7a9f76 into zeroc-ice:3.7 Oct 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@externl externl externl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pepone @externl