Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress BinaryFormatter-related code for .NET 8.0 #1550

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

bernardnormier
Copy link
Member

Fixes #1548

I also added:

<TreatWarningsAsErrors>true</TreatWarningsAsErrors>

Not sure why this wasn't set already.

@pepone
Copy link
Member

pepone commented Oct 12, 2023

There are a few tests that need fixes to not use serializable objects:

  • Ice/optional
  • Ice/seqMapping
  • Ice/stream

@bernardnormier
Copy link
Member Author

You're right, I forgot to update these tests. I've fixed it!

Copy link
Member

@externl externl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bernardnormier bernardnormier merged commit fbc2d6f into zeroc-ice:3.7 Oct 12, 2023
1 of 2 checks passed
@bernardnormier bernardnormier deleted the fix1548 branch May 10, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated C# code does not compile with .NET 8 RC1
3 participants