Remove unnecessary escape characters. #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
approved these changes
Oct 24, 2023
externl
approved these changes
Oct 24, 2023
InsertCreativityHere
force-pushed
the
remove-unnecessary-escape-sequences
branch
from
a3629db
to
0c53098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1560 by removing the invalid escape sequences.
The escaped commas seem like an accident, it's trying to show a literal backslash, but is getting picked up as an escape sequence.
The escaped square brackets were just a hold-over from our old syntax for links: 7c9cc22
Nowadays we use the newer
@linktag syntax, andslice2htmlwill emit a warning if it sees this old syntax.This PR removes the brackets, so this means running
slice2htmlon these files will produce warnings.