Update Ice logo (#1511) #1564
Merged
Update Ice logo (#1511) #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
approved these changes
Oct 24, 2023
pepone
approved these changes
Oct 24, 2023
|
Should we use a different logo for datastorm? |
|
I also find it a little weird to use the Ice logo for Datastorm. |
We dont really have a datastorm logo yet. I implemented the changes per #1511. I think its fine for now and we can look into having a separate DataStorm logo the future. Plus we already bundle DataStorm wiht the Ice product on https://zeroc.com/ice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1511
Updates the Ice repo per #1511. Will add the ice logo to other repos in separate commits. Want this one to get reviewed since I am unfamiliar with ice packaging and where it pulls the logos from.
Edit: