Add Ice 2 Slice translator #1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
requested review from
externl,
bernardnormier and
InsertCreativityHere
bernardnormier
approved these changes
Dec 5, 2023
| return os.str(); | ||
| } | ||
|
|
||
| string typeToCsString(const TypePtr& type, bool optional) |
There was a problem hiding this comment.
Not clear why we need this in ice2slice.
There was a problem hiding this comment.
To map cs::generic metadata to cs::type
bernardnormier
approved these changes
Dec 5, 2023
Co-authored-by: Joe George <[email protected]>
Co-authored-by: Joe George <[email protected]>
Co-authored-by: Joe George <[email protected]>
InsertCreativityHere
approved these changes
Dec 13, 2023
| OperationPtr operation = OperationPtr::dynamicCast(contained); | ||
| if (operation) | ||
| { | ||
| std::map<std::string, StringList> parameterDocs = comment->parameters(); |
There was a problem hiding this comment.
Should we also handle the 'returns', 'exceptions' (now @throws) and 'seealso' tags?
| for (ParamDeclList::const_iterator it = parameters.begin(); it != parameters.end(); it++) | ||
| { | ||
| ParamDeclPtr param = *it; | ||
| if (!param->isOutParam()) |
There was a problem hiding this comment.
And also map @param to @returns?
Slice lets you do:
@returns foo: something
@returns bar: i don't know
The same syntax as @param in the case where your return elements have names.
|
I will deal with the doc comments in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
ice2slicetranslator, that allows to convert Ice.icefiles to IceRPC.slicefiles.There are still a few things to do, especially to deal with things that don't have equivalent in
.slicefiles.