Port Glacier2 to C++11 #1615
Merged
Port Glacier2 to C++11 #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
approved these changes
Dec 20, 2023
externl
approved these changes
Dec 20, 2023
.github/workflows/ci.yml
Outdated
| @@ -17,6 +17,6 @@ jobs: | |||
| - name: Checkout repository | |||
| uses: actions/checkout@v3 | |||
| - name: Build | |||
| run: make -j8 V=1 | |||
| run: make -j8 V=1 CONFIGS="shared cpp11-shared" | |||
There was a problem hiding this comment.
Should this be cpp98-shared cpp11-shared?
There was a problem hiding this comment.
No, we call "cpp98-shared" simply "shared".
There was a problem hiding this comment.
shared was renamed to cpp98-shared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back to main the Glacier2 C++11 port @externl did in #629
There are some minor build fixes on top of it