Simplify includes in generated c++ code #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
approved these changes
Dec 22, 2023
bernardnormier
force-pushed
the
simplify-gen-include
branch
from
876de52
to
65a7d76
Compare
bernardnormier
force-pushed
the
simplify-gen-include
branch
from
65a7d76
to
097d810
Compare
bernardnormier
force-pushed
the
simplify-gen-include
branch
from
097d810
to
c3e1a5e
Compare
bernardnormier
force-pushed
the
simplify-gen-include
branch
from
c3e1a5e
to
1e9b431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the includes generated by slice2cpp.
It's now either
#include <Ice/Ice.h>or nothing (when the Slice file specifies[[cpp:no-default-include]].I also added an ICE_BUILDING_GENERATED_CODE that skips a large part of Ice/Ice.h when building generated c++ code.
This PR is layered over #1619, so I recommend reviewing the difference:
https://github.com/bernardnormier/ice/compare/xlocalgen-cpp...bernardnormier:ice:simplify-gen-include?expand=1