Parser improvements from #756 #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InsertCreativityHere
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Looks good, just minor things, or things I think should of been kept from #756.
Comment on lines
+414
to
+415
| "byte", | ||
| "bool", |
There was a problem hiding this comment.
I think it'd be nice to swap these like #756 did, and like this PR does in the keyword list.
It felt more logical to me to have all the numeric types together instead of bool in the middle of them.
Suggested change
| "byte", | |
| "bool", | |
| "bool", | |
| "byte", |
There was a problem hiding this comment.
Note that you would have to also swap the order of the Kind enumerators to match, since we depend on the ordering. But I think that the order should be swapped there anyways.
There was a problem hiding this comment.
I'd rather leave this swap to another PR as I would need to update the code generators accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the parser (including grammar) improvements from #756.
#756 also added new types (unsigned and varints), but this PR doesn't add them.