Replace Ice::optional and IceUtil::Optional by std::optional #1641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces both Ice::optional and IceUtil::Optional by std::optional, while providing aliases for backwards source compatibility.
I believe the only source-incompatible change is the old IceUtil::Optional provides
get()
as an alias forvalue()
:https://doc.zeroc.com/ice/3.7/language-mappings/c++98-mapping/client-side-slice-to-c++98-mapping/c++98-mapping-for-optional-values
https://doc.zeroc.com/api/ice/3.7/cpp98/classIceUtil_1_1Optional.html
Note: this PR does not replace all Ice::optional / IceUtil::Optional by std::optional, to show that existing code using these names would not be affected. A follow-up cleanup PR should make this global replace.