Slice library cleanup, remove dead code and other minor fixes #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
requested review from
externl,
bernardnormier and
InsertCreativityHere
pepone
commented
Jan 17, 2024
| DictionaryPtr p = dynamic_pointer_cast<Dictionary>(matches.front()); | ||
| if(p) | ||
| { | ||
| if(_unit->ignRedefs()) |
There was a problem hiding this comment.
ignRedefs was always false, I think it was used before by local Slice and scripting languages.
pepone
commented
Jan 17, 2024
| @@ -5163,11 +4747,6 @@ Slice::Const::Const(const ContainerPtr& container, const string& name, const Typ | |||
| _value(value), | |||
| _literal(literal) | |||
| { | |||
| if(valueType == 0) | |||
There was a problem hiding this comment.
this seems like some leftover from debugging the compilers
pepone
commented
Jan 17, 2024
| { | ||
| ContainedPtr contained2 = dynamic_pointer_cast<Contained>(_type); | ||
| return (contained2 && contained2 == contained); | ||
| } |
There was a problem hiding this comment.
this code was wrong with the upgrade to shared_ptr, and still everything worked! noticed it is not used anymore.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up PR to #1674, removes unused code from Slice library