Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ice for Objective-C #1695

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Conversation

bernardnormier
Copy link
Member

This PR removes Ice for Objective-C.

Note: we still have some Objective-C and Objective-C++ code in cpp and swift. I also kept the Objective-C and Objective-C compilation rules in Make.project.rules as they are used when building cpp for iOS.

Copy link
Member

@externl externl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The ci action in the .github folder should also be updated to remove objc.

Copy link
Member

@pepone pepone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think we can also remove the rules for .m and .mm from

ifneq ($(filter %.mm,$4),)
# Rules to build Objective-C++ sources from <srcdir>
$3/%.o: $1/%.mm
$3/%.o: $1/%.mm
$(E) "Compiling [$8-$9] $$<"
$(Q)$(or $($8_cxx),$(platform_cxx)) $(CXXFLAGS) $(call depend-cppflags,$3/$$*.Td,$$@)\
$(strip $6) $(CPPFLAGS) -std=c++17 -c $$< -o $$@
$(Q)$(MV) $3/$$*.Td $3/$$*.mm.d
endif
ifneq ($(filter %.m,$4),)
# Rules to build Objective-C sources from <srcdir>
$3/%.o: $1/%.m
$3/%.o: $1/%.m
$(E) "Compiling [$8-$9] $$<"
$(Q)$(or $($8_cxx),$(platform_cxx)) $(CXXFLAGS) $(call depend-cppflags,$3/$$*.Td,$$@)\
$(strip $6) $(CPPFLAGS) -c $$< -o $$@
$(Q)$(MV) $3/$$*.Td $3/$$*.m.d
endif

@bernardnormier
Copy link
Member Author

Looks good, I think we can also remove the rules for .m and .mm from

We can't and shouldn't. See the main description of this PR.

@bernardnormier bernardnormier merged commit 2e495e5 into zeroc-ice:main Jan 19, 2024
1 check passed
@bernardnormier bernardnormier deleted the remove-objc branch May 10, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants