-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Ice for Objective-C #1695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The ci action in the .github
folder should also be updated to remove objc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think we can also remove the rules for .m
and .mm
from
Lines 130 to 148 in df5e937
ifneq ($(filter %.mm,$4),) | |
# Rules to build Objective-C++ sources from <srcdir> | |
$3/%.o: $1/%.mm | |
$3/%.o: $1/%.mm | |
$(E) "Compiling [$8-$9] $$<" | |
$(Q)$(or $($8_cxx),$(platform_cxx)) $(CXXFLAGS) $(call depend-cppflags,$3/$$*.Td,$$@)\ | |
$(strip $6) $(CPPFLAGS) -std=c++17 -c $$< -o $$@ | |
$(Q)$(MV) $3/$$*.Td $3/$$*.mm.d | |
endif | |
ifneq ($(filter %.m,$4),) | |
# Rules to build Objective-C sources from <srcdir> | |
$3/%.o: $1/%.m | |
$3/%.o: $1/%.m | |
$(E) "Compiling [$8-$9] $$<" | |
$(Q)$(or $($8_cxx),$(platform_cxx)) $(CXXFLAGS) $(call depend-cppflags,$3/$$*.Td,$$@)\ | |
$(strip $6) $(CPPFLAGS) -c $$< -o $$@ | |
$(Q)$(MV) $3/$$*.Td $3/$$*.m.d | |
endif |
We can't and shouldn't. See the main description of this PR. |
This PR removes Ice for Objective-C.
Note: we still have some Objective-C and Objective-C++ code in cpp and swift. I also kept the Objective-C and Objective-C compilation rules in Make.project.rules as they are used when building cpp for iOS.