Update IceUtilInternal::Random implementation to use std::random #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
approved these changes
Jan 23, 2024
|
For a follow-up PR: since we call random and generateRandom only a few times (very few), my preference would be to get rid of this IceUtilInternal helper and just use the correct random function where we need it. |
bernardnormier
approved these changes
Jan 23, 2024
| std::random_device rd; | ||
| std::mt19937 rng(rd()); | ||
| thread_local static std::random_device rd; | ||
| thread_local static std::mt19937 rng(rd()); |
There was a problem hiding this comment.
We can't write this as something like?
thread_local static std::mt19937 rng(std::random_device());There was a problem hiding this comment.
Probably, I will check when I do the follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.