Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AsyncResult AMI mapping #1737

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Conversation

pepone
Copy link
Member

@pepone pepone commented Jan 31, 2024

No description provided.

cpp/src/slice2cs/Gen.cpp Outdated Show resolved Hide resolved
Copy link
Member

@bernardnormier bernardnormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for the fix in Gen.cpp.

You should also remove AsyncResult.cs

cpp/src/slice2cs/Gen.cpp Outdated Show resolved Hide resolved
csharp/test/TestCommon/TestHelper.cs Show resolved Hide resolved
csharp/test/Ice/operations/OnewaysAMI.cs Outdated Show resolved Hide resolved
csharp/test/Ice/ami/AllTests.cs Show resolved Hide resolved
csharp/test/Ice/ami/AllTests.cs Show resolved Hide resolved
cb = new ProgresCallback();
p.opWithPayloadAsync(seq, progress: cb);
cb = new ProgressCallback();
_ = p.opWithPayloadAsync(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should cleanup the code below to use await instead of Wait()

Copy link
Member

@bernardnormier bernardnormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

csharp/test/Ice/ami/AllTests.cs Outdated Show resolved Hide resolved
csharp/test/Ice/hold/AllTests.cs Outdated Show resolved Hide resolved
@pepone pepone merged commit dfc1991 into zeroc-ice:main Feb 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants