Cpp98 removal #1747
Merged
Cpp98 removal #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -94,17 +99,17 @@ | |||
| <ItemDefinitionGroup Condition="'$(ICE_BIN_DIST)' != 'all'"> | |||
| <ClCompile> | |||
| <AdditionalIncludeDirectories>$(IceHome)\cpp\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories> | |||
| <AdditionalIncludeDirectories>$(IceHome)\cpp\include\generated\$(IceCppMapping)\$(Platform)\$(IceConfiguration);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories> | |||
| <AdditionalIncludeDirectories>$(IceHome)\cpp\include\generated\cpp11\$(Platform)\$(Configuration);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories> | |||
There was a problem hiding this comment.
I guess it's related to the TODO: remove cpp11 in ice.test.props.
| @@ -987,95 +978,6 @@ Slice::Gen::generate(const UnitPtr& p) | |||
| Cpp11CompatibilityVisitor compatibilityVisitor(H, C, _dllExport); | |||
| p->visit(&compatibilityVisitor, false); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
You should also remove all these C++98 visitors: ProxyDeclVisitor, DeclVisitor, etc. I am pretty sure they are independent of the Cpp11 visitors.
bernardnormier
approved these changes
Feb 2, 2024
externl
approved these changes
Feb 2, 2024
Comment on lines
10
to
11
| // Part of the C++98 mapping, and "internal" definitions when building Ice | ||
| // with the C++11 mapping |
There was a problem hiding this comment.
Maybe remove C++98 from the comment?
cpp/include/Ice/ProxyHandle.h
Outdated
There was a problem hiding this comment.
Should this file be deleted? GitHub says it's just empty now. Though it might just be having issues with the size of this PR. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the C++98 mapping and the usage of ICE_CPP11_MAPPING. We have a single C++ mapping now.
There are more things to cleanup, like removing the usage of helper macros like ICE_UNCHECKED_CAST, but I let this for follow-up PRs.