Use local static const / constexpr for a strings #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Feb 22, 2024
| C << nl << "::std::pair<const ::std::string*, const ::std::string*> r = " | ||
| << "::std::equal_range(" << flatName << ", " << flatName << " + " << allOpNames.size() | ||
| C << sp; | ||
| C << nl << "static constexpr ::std::string_view allOperations[] = "; |
There was a problem hiding this comment.
It's nicer to use a constexpr string_view since it gets initialized at a compile-time. Lots of statics increase start-up time.
| @@ -107,10 +107,6 @@ class Gen | |||
| bool visitClassDefStart(const ClassDefPtr&) final; | |||
| bool visitExceptionStart(const ExceptionPtr&) final; | |||
|
|
|||
| // TODO: temporary - move to InterfaceVisitor. | |||
There was a problem hiding this comment.
Removing these functions was the main goal of this PR.
| @@ -2334,11 +2286,14 @@ Slice::Gen::ProxyVisitor::visitOperation(const OperationPtr& p) | |||
| C << inParamsImplDecl << ("const " + getUnqualified("::Ice::Context&", interfaceScope) + " context"); | |||
| C << epar << " const"; | |||
| C << sb; | |||
| // TODO: switch to string_view and constexpr. | |||
There was a problem hiding this comment.
Switching to string_view requires some work in OutgoingAsync. Maybe it could use a string_view too.
pepone
approved these changes
Feb 23, 2024
| C.spar("{ "); | ||
| for (auto typeId : p->ids()) | ||
| { | ||
| C << '"' + typeId + '"'; |
There was a problem hiding this comment.
I think it would be clear to use << instead of +.
There was a problem hiding this comment.
No, this doesn't work. Each "<<" inserts a comma.
cpp/src/slice2cpp/Gen.cpp
Outdated
Comment on lines
3283
to
3286
| for (auto opName : allOpNames) | ||
| { | ||
| C << '"' + opName + '"'; | ||
| } |
externl
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the generated code to use local static const / constexpr for the list of operations and ids used by the generated code.
It also updates the server-side implementation of ice_isA: there is now a single implementation (in Ice::Object) that calls ice_ids(). It's less efficient than the old implementation but simpler - and if the efficiency of ice_isA matters to your app, something is very wrong with this app.