Replace C++ CountDownLatch with std::promise #1854
Conversation
| call->run(); | ||
| dispatchPromise.set_value(); |
There was a problem hiding this comment.
Is this run call guaranteed to never throw?
There was a problem hiding this comment.
I don't think so. This keeps the previous behavior. Maybe is more correct to catch the exception and use it to complete the promise.
There was a problem hiding this comment.
As far as I can tell, Ice::DispatcherCallPtr is a C++98 API. Why are we still using it?
There was a problem hiding this comment.
Seems SessionHelper is the only place where we still use it. I will remove it.
There was a problem hiding this comment.
According to the Ice Manual:
The call given to the dispatcher takes no parameters, returns nothing, and never throws any exception back to the dispatcher.
We should mark it noexcept. So I wouldn't worry about the exception is throws.
There was a problem hiding this comment.
And in this particular case, all the "callbacks" are SessionHelper code, right?
There was a problem hiding this comment.
The callbacks call to the user provided SessionCallback.
This reverts commit 496d38c.
No description provided.