Merge Properties and PropertiesI, switch to string_view #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Mar 7, 2024
| @@ -13,11 +13,14 @@ | |||
| #include "Initialize.h" | |||
| #include "PluginF.h" | |||
| #include "Properties.h" | |||
| #include "ProxyF.h" | |||
| #include "Proxy.h" | |||
There was a problem hiding this comment.
My cleanup of the headers included by Properties.h revealed a bug in this include list.
| @@ -117,7 +117,7 @@ ICE_API PropertiesPtr createProperties(); | |||
| * @return A new property set initialized with the property settings | |||
| * that were removed from the argument vector. | |||
| */ | |||
| ICE_API PropertiesPtr createProperties(StringSeq& seq, const PropertiesPtr& defaults = 0); | |||
| ICE_API PropertiesPtr createProperties(StringSeq& seq, const PropertiesPtr& defaults = nullptr); | |||
There was a problem hiding this comment.
I am wonder if we should just remove these functions that are now equivalent to a call to make_shared<Properties>(...)
| _properties = p._properties; | ||
| } | ||
|
|
||
| Ice::Properties::Properties(StringSeq& args, const PropertiesPtr& defaults) |
There was a problem hiding this comment.
It's just the implementation that was in PropertiesI - I didn't change anything.
pepone
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges Properties and PropertiesI and replaces "const string&" by string_view in the Properties API.