Switch IceInternal::Buffer underlying type to std::byte #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
commented
Mar 13, 2024
| scope, | ||
| seq->typeMetaData(), | ||
| typeCtx | (inWstringModule(seq) ? TypeContext::UseWstring : TypeContext::None)); | ||
| string s; |
There was a problem hiding this comment.
typeToString has no context (AFAIT) to detect the type is for a sequence. I thought of adding another type context, but ultimately decided against this since it's only relevant in a few specific places.
bernardnormier
approved these changes
Mar 13, 2024
cpp/include/Ice/OutputStream.h
Outdated
| @@ -325,12 +325,12 @@ namespace Ice | |||
| assert(v >= 0); | |||
| if (v > 254) | |||
| { | |||
| *dest++ = std::uint8_t(255); | |||
| *dest++ = std::byte(255); | |||
| @@ -1174,12 +1180,18 @@ Ice::InputStream::read(wstring& v) | |||
| if (_instance) | |||
| { | |||
| const WstringConverterPtr& wstringConverter = _instance->getWstringConverter(); | |||
| wstringConverter->fromUTF8(i, i + sz, v); | |||
| wstringConverter->fromUTF8( | |||
| reinterpret_cast<const uint8_t*>(i), | |||
There was a problem hiding this comment.
We should fix fromUTF8 to take bytes like other APIs.
| @@ -39,7 +39,7 @@ namespace | |||
| // | |||
| // Return unused bytes | |||
| // | |||
| _stream.resize(static_cast<size_t>(firstUnused - _stream.b.begin())); | |||
| _stream.resize(static_cast<size_t>(firstUnused - reinterpret_cast<uint8_t*>(_stream.b.begin()))); | |||
There was a problem hiding this comment.
We should fix the UTF8Buffer API to use bytes.
| scope, | ||
| seq->typeMetaData(), | ||
| typeCtx | (inWstringModule(seq) ? TypeContext::UseWstring : TypeContext::None)); | ||
| string s; |
pepone
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #1825, namely
sequence<byte>tostd::vector<std::byte>by default