Icessl protocols #2026
Merged
Icessl protocols #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One downside with this change is that the user can no longer change the protocols for the Ice services. Is this an issue? |
We can keep it and support only 1.2 and 1.3, there is no reason to support anything older. Would you prefer that? I don't see a reason to allow enabling older versions, which might be disabled by the platform and not work. |
|
Good point, I forgot this setting is not useful with newer versions of TLS. |
externl
approved these changes
Apr 4, 2024
bernardnormier
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes support for setting SSL protocols using IceSSL properties,
IceSSL.Protocols,IceSSL.ProtocolVersionMax, andIceSSL.ProtocolVersionMin.The SSL transport would use the system defaults, there is usually no need to change this. For advanced use cases, you can change the system defaults or use the IceSSL native API.