-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the platform native APIs with C++ SSL transport #2063
Merged
Merged
Changes from 51 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
e299cf6
Use ssl native API
pepone 6b9286f
Checkpoint
pepone ddb1fb4
Checkpoint
pepone c36953a
SChannel fixes
pepone f176d7d
SChannel certificate validation fixes
pepone b18f2f5
SecureTransport fixes
pepone be82bae
Add TLS 1.2 protocol name
pepone c877a81
OpenSSL fixes
pepone ed9711b
Cleanup
pepone 319ac21
Merge remote-tracking branch 'origin/main' into ssl-native
pepone ae94cd4
Cleanup
pepone 9d13c39
Merge remote-tracking branch 'origin/main' into ssl-native
pepone 2dfc388
Checkpoint
pepone 1e48e73
Additional fixes
pepone 02ac138
Fix clang format
pepone d61d27f
Doc comment fixes
pepone 3588bd4
Script language fixes
pepone 512c596
Checkpoint
pepone fbc6712
Fix Swift tests
pepone f4e9f30
Restore EOF_WHILE_READING
pepone c9ff80c
SChannel fixes
pepone f48f3cf
Retrieve OpenSSL peer certificate chain
pepone 78c2921
OpenSSL fixes
pepone 42bc483
Fix clang-format
pepone 5030a1e
macOS fixes
pepone ae67d2f
Add default OpenSSL certificate verification callback
pepone 4b2a152
Merge remote-tracking branch 'origin/main' into ssl-native
pepone f84b577
SecureTransport fixes
pepone 54c4b49
Schannel fixes
pepone 4d7a2f6
SecureTransport fixes
pepone dbc3234
Cleanup
pepone b58840b
SecureTransport & OpenSSL fixes
pepone 460129a
Checkpoint
pepone 0bec18e
Merge remote-tracking branch 'origin/main' into ssl-native
pepone 89d2d1b
SecureTransport updates
pepone aec11f5
Improve OpenSSL usage doc comments
pepone 1607c42
Retain/Release SecureTransport trusted roots
pepone bd70794
OpenSSL bug with bogus _sslCtx reference
pepone 7c8290f
SChannel updates
pepone ab5d208
Update cpp/src/IceSSL/OpenSSLTransceiverI.cpp
pepone 2a6c820
Update cpp/src/IceSSL/SecureTransportTransceiverI.cpp
pepone 4326856
Update cpp/src/IceSSL/SecureTransportTransceiverI.cpp
pepone 063dbc8
Update cpp/src/IceSSL/SChannelEngine.cpp
pepone d8851b4
Update cpp/src/IceSSL/OpenSSLTransceiverI.cpp
pepone 79426bd
Update cpp/src/IceSSL/SChannelTransceiverI.cpp
pepone ed26e4e
Review fixes
pepone 97c3dc6
More review fixes
pepone e0bf553
Fix typo
pepone f406d54
Cleanup
pepone 3f0b970
Merge remote-tracking branch 'origin/main' into ssl-native
pepone 456022a
Build fixes
pepone 01f506f
Additional review fixes
pepone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice API! |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
// | ||
// Copyright (c) ZeroC, Inc. All rights reserved. | ||
// | ||
|
||
#ifndef ICE_SSL_CONFIG | ||
#define ICE_SSL_CONFIG | ||
|
||
#if defined(_WIN32) | ||
# define ICE_USE_SCHANNEL | ||
// We need to include windows.h before wincrypt.h. | ||
// clang-format off | ||
# ifndef NOMINMAX | ||
# define NOMINMAX | ||
# endif | ||
# include <windows.h> | ||
# include <wincrypt.h> | ||
// clang-format on | ||
// SECURITY_WIN32 or SECURITY_KERNEL are defined before including security.h indicating who is compiling the code. | ||
# ifdef SECURITY_WIN32 | ||
# undef SECURITY_WIN32 | ||
# endif | ||
# ifdef SECURITY_KERNEL | ||
# undef SECURITY_KERNEL | ||
# endif | ||
# define SECURITY_WIN32 1 | ||
# include <schannel.h> | ||
# include <security.h> | ||
# include <sspi.h> | ||
# undef SECURITY_WIN32 | ||
#elif defined(__APPLE__) | ||
# define ICE_USE_SECURE_TRANSPORT | ||
# include <Security/SecureTransport.h> | ||
# include <Security/Security.h> | ||
#else | ||
# define ICE_USE_OPENSSL | ||
# include <openssl/ssl.h> | ||
#endif | ||
|
||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
gdb
necessary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use it to debug the tests, I think it is fine for a development container.