Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the platform native APIs with C++ SSL transport #2063
Use the platform native APIs with C++ SSL transport #2063
Changes from 11 commits
e299cf6
6b9286f
ddb1fb4
c36953a
f176d7d
b18f2f5
be82bae
c877a81
ed9711b
319ac21
ae94cd4
9d13c39
2dfc388
1e48e73
02ac138
d61d27f
3588bd4
512c596
fbc6712
f4e9f30
c9ff80c
f48f3cf
78c2921
42bc483
5030a1e
ae67d2f
4b2a152
f84b577
54c4b49
4d7a2f6
dbc3234
b58840b
460129a
0bec18e
89d2d1b
aec11f5
1607c42
bd70794
7c8290f
ab5d208
2a6c820
4326856
063dbc8
d8851b4
79426bd
ed26e4e
97c3dc6
e0bf553
f406d54
3f0b970
456022a
01f506f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice API!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume it's invalid for the returned
CredHandle
to benullptr
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, We should throw in this case, which we currently don't do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use
std::string_view
overconst std::string&
in new APIs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the string reference because it is more convenient to call the native APIs that require a NULL-terminated string.