Replace ConnectionTimeoutException by ConnectionIdleException #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentoi
approved these changes
Apr 29, 2024
pepone
approved these changes
Apr 29, 2024
externl
approved these changes
Apr 29, 2024
|
|
||
| % Copyright (c) ZeroC, Inc. All rights reserved. | ||
|
|
||
| classdef ConnectionIdleException < Ice.LOcalException |
There was a problem hiding this comment.
Suggested change
| classdef ConnectionIdleException < Ice.LOcalException | |
| classdef ConnectionIdleException < Ice.LocalException |
There was a problem hiding this comment.
I don't know MATLAB well, doe this class ever get loaded during the tests? I would expect it to fail.
Co-authored-by: Jose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes replaces ConnectionTimeoutException by ConnectionIdleException in C++ and derived languages.
That's the exception that is "thrown" by the idle check when it aborts a connection.