Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch 'Ice/optional' Tests to use Optional Structs Instead of Optional Classes #2094

Merged
merged 6 commits into from
May 1, 2024
Merged

Switch 'Ice/optional' Tests to use Optional Structs Instead of Optional Classes #2094

merged 6 commits into from
May 1, 2024

Commits on Apr 30, 2024

  1. Switch some tests to use optional structs instead of optional classes.

    @InsertCreativityHere
    InsertCreativityHere committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    7d3c7c1 View commit details
    Browse the repository at this point in the history

  2. First round of fixes to other languages

    @InsertCreativityHere
    InsertCreativityHere committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9947059 View commit details
    Browse the repository at this point in the history

  3. Hopefully the last of them.

    @InsertCreativityHere
    InsertCreativityHere committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    356a13e View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Remove send/return optional test functions.

    @InsertCreativityHere
    InsertCreativityHere committed May 1, 2024
    Configuration menu
    Copy the full SHA
    11ae20f View commit details
    Browse the repository at this point in the history

  2. We were reusing a variable later on in a test...

    @InsertCreativityHere
    InsertCreativityHere committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1468b4c View commit details
    Browse the repository at this point in the history

  3. More variable re-use.

    @InsertCreativityHere
    InsertCreativityHere committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8725b8d View commit details
    Browse the repository at this point in the history