Rename IceSSL namespace to Ice::SSL #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
approved these changes
May 6, 2024
cpp/src/Ice/Instance.cpp
Outdated
| @@ -3,7 +3,7 @@ | |||
| // | |||
|
|
|||
| #include "Instance.h" | |||
| #include "../IceSSL/SSLEngine.h" | |||
| #include "../Ice/SSL/SSLEngine.h" | |||
There was a problem hiding this comment.
I don't think we should use this include syntax.
If it's a public header, use "Ice/SSL/SSLEngine.h". If it's a private (local) header, use "SSL/SSLEngine.h".
There was a problem hiding this comment.
Seems like this is likely a typo.
|
|
||
| #include "Certificate.h" | ||
|
|
||
| #include <openssl/pem.h> | ||
| #include <openssl/x509v3.h> | ||
|
|
||
| namespace IceSSL::OpenSSL | ||
| namespace Ice::SSL::OpenSSL |
There was a problem hiding this comment.
If we keep this public API, I would prefer a prefix (OpenSSLCertificate) over a sub-namespace, just like we did for the authentication options.
externl
approved these changes
May 6, 2024
cpp/src/Ice/Instance.cpp
Outdated
| @@ -3,7 +3,7 @@ | |||
| // | |||
|
|
|||
| #include "Instance.h" | |||
| #include "../IceSSL/SSLEngine.h" | |||
| #include "../Ice/SSL/SSLEngine.h" | |||
There was a problem hiding this comment.
Seems like this is likely a typo.
| @@ -34,10 +34,10 @@ namespace | |||
| }; | |||
| using CertInfoHolderPtr = shared_ptr<CertInfoHolder>; | |||
|
|
|||
| class SCHannelX509ExtensionI : public X509Extension | |||
| class ScHannelX509ExtensionI : public X509Extension | |||
There was a problem hiding this comment.
Is this casing correct? Shouldn't these be Schannel?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames IceSSL namespace to Ice::SSL, It also fixes SSL and Schannel spelling