Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes removing nonmutating.
This is a sister PR to #2121, which removed the last of the 'nonmutating' metadata checks.
As-of this PR, we should no longer be sending nonmutating, nor making any distinction between it and idempotent.
This PR:
ice_isA
,ice_ping
,ice_id
,ice_ids
) to useOperationMode::Idempotent
, instead ofOperationMode::Nonmutating
which they're currently using.OperationMode
In Ruby, I couldn't find how/where we specify the operation mode these 4 built-ins use...
We define the operations here (v) but I couldn't figure out how an operation mode gets specified.
ice/ruby/src/IceRuby/Proxy.cpp
Lines 1214 to 1217 in 6002b49