Remove More Optional Class Testing #2139
Conversation
InsertCreativityHere
requested review from
pepone,
externl,
bernardnormier and
ReeceHumphreys
cpp/test/Ice/logger/log.txt
Outdated
| @@ -0,0 +1 @@ | |||
| -- 05/08/24 16:59:34115 aplicación: info: XXX | |||
There was a problem hiding this comment.
It looks like this file was added by accident.
There was a problem hiding this comment.
Good catch. I was committing too hastily.
Removed.
There was a problem hiding this comment.
Maybe we should update the .gitignore to catch this file if it was generated.
| bool supportsRequiredParams(); | ||
|
|
||
| bool supportsJavaSerializable(); | ||
|
|
||
| bool supportsCsharpSerializable(); | ||
|
|
There was a problem hiding this comment.
Should also remove supportsCsharpSerialize above. We dropped support for C# serialization a while ago.
There was a problem hiding this comment.
and supportsRequiredParams. I can't find any call to this operation.
There was a problem hiding this comment.
Yes, this is only used by the Java mapping.
Java is the only language which returns true for this, and it's also the only language that calls it.
At the top of Ice/Optional/AllTests.java
That's part of the Java cleanup I mentioned in the top description.
This PR follows #2094 in gutting more of the Ice/optional tests.
This is the penultimate PR, since we're there's still some optional classes being passed around via the streaming APIs,
and the Java tests in particular can use some serious cleaning up since 'java:optional' is dead metadata.
It's mostly just removal, so feel free to only look at the languages you care about.
Anyways, this PR:
supportsNullOptionalopMGtests which test the interplay ofmarshaled-resultwith optional classesIt's a simple test, and believe-it-or-not, it's the only test I see that ensures optional data members survive a round trip from client->server->client, which seems worth keeping a test for.