Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Testing of Optional Sequences/Dictionaries which hold Classes #2201

Conversation

InsertCreativityHere
Copy link
Member

The title pretty much says it.
We still extensively test optional sequences and dictionaries of other types. So it's probably fine to just remove these tests.

@InsertCreativityHere InsertCreativityHere marked this pull request as ready for review May 20, 2024 19:21
@pepone
Copy link
Member

pepone commented May 20, 2024

Do we test the Sequence/Dictionary of optionals in some other place?

@InsertCreativityHere
Copy link
Member Author

If you mean something like:

class C {
    optional(4) int i;
}
sequence<C> CS;

myTest(p: CS); // test function that uses `CS`.

Then no, if this PR is merged as is, we won't have any testing for these things.
We have lots of tests for 'optional sequences', but none for 'sequences of optionals'.

To be fair, right now we only tangentially have these tests. Because we only have tests of
'optional sequences of classes with optionals'. I don't believe we have tests for
'non-optional sequences of classes with optionals'.


Originally I tried to adapt these tests to continue testing them, but the structure of the Optional test made it difficult to do.
If we feel this is an important case to cover (which I could somewhat agree to) I think it's still best to delete these tests, but add new ones that test specifically "non-optional sequences of classes with optionals".

@InsertCreativityHere InsertCreativityHere merged commit 33cffdb into zeroc-ice:main May 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants