Remove unused local exceptions #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Jun 7, 2024
| * This exception indicates a request was interrupted. | ||
| * \headerfile Ice/Ice.h | ||
| */ | ||
| class ICE_API OperationInterruptedException : public LocalException |
There was a problem hiding this comment.
Java-only local exception
| * This exception indicates that a response for an unknown request ID has been received. | ||
| * \headerfile Ice/Ice.h | ||
| */ | ||
| class ICE_API UnknownRequestIdException : public ProtocolException |
There was a problem hiding this comment.
Not used since at least Ice 3.7. An unknown request ID is ok as it corresponds to canceled request.
| @@ -262,23 +262,6 @@ open class UnknownUserException: UnknownException { | |||
| } | |||
| } | |||
|
|
|||
| /// This exception is raised if the Ice library version does not match the version in the Ice header files. | |||
| open class VersionMismatchException: LocalException { | |||
There was a problem hiding this comment.
That's a C++-only exception that doesn't apply to C++-derived mappings.
| @@ -1436,23 +1385,6 @@ open class MemoryLimitException: MarshalException { | |||
| } | |||
| } | |||
|
|
|||
| /// This exception is raised when a string conversion to or from UTF-8 fails during marshaling or unmarshaling. | |||
| open class StringConversionException: MarshalException { | |||
There was a problem hiding this comment.
That's a C++ decoding exception that doesn't apply to Swift and MATLAB since they perform their own string decoding without throwing this exception.
pepone
approved these changes
Jun 10, 2024
externl
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleanup PR removes a number of unused local exceptions.