Consolidate/refactor local exceptions in C# #2338
Conversation
| { | ||
| } | ||
|
|
||
| public override string ice_id() => "::Ice::ObjectNotExistException"; |
There was a problem hiding this comment.
We use ice_id for metrics and more.
| - Consolidate and refactor the exceptions derived from LocalException. | ||
| | Local exception in Ice 3.7 | Replacement | | ||
| |-------------------------------------|----------------------------| | ||
| | BadMagicException | ProtocolException (base) | |
There was a problem hiding this comment.
Also useful as a guide when updating other language mappings.
| setState(StateClosed, | ||
| new ConnectionAbortedException( | ||
| "Connection close forcefully by the application.", | ||
| closedByApplication: true)); |
There was a problem hiding this comment.
Is closeByApplication ever false?
There was a problem hiding this comment.
Not currently - this exception is only thrown when the application aborts the connection "manually".
We need t closedByApplication to not retry a connection that was closed manually - that's the existing retry logic.
What about replacing ConnectionIdleException by ConnectionAbortedException with message + closedByApplication = false?
ConnectionLostException (a SocketException) also means "connection aborted". Should we replace it by ConnectionAbortedException?
All for a follow-up PR.
This PR reworks the local exceptions in C#. It should be a model for the other language mappings.
In particular: