Update ObjectAdapter deactivate semantics in C++ #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new default object adapter on Communicator
pepone
approved these changes
Oct 15, 2024
| IceInternal::OutgoingConnectionFactory::setDefaultObjectAdapter(ObjectAdapterPtr adapter) noexcept | ||
| { | ||
| lock_guard lock(_mutex); | ||
| _defaultObjectAdapter = dynamic_pointer_cast<ObjectAdapterI>(adapter); |
There was a problem hiding this comment.
Should we assert the cast succeed?
There was a problem hiding this comment.
There is no situation where this dynamic_pointer_cast can fail.
If you're concerned about users creating their own ObjectAdapter, we can make ObjectAdapter's constructor protected.
Co-authored-by: Joe George <[email protected]>
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add Communicator::get/setDefaultObjectAdapter in C++, Swift and Python.
It's the C++ version of #2888 and #2894.