Bring DataStorm into Ice 3.8 #2902
Conversation
| #ifndef DATASTORM_CONFIG_H | ||
| #define DATASTORM_CONFIG_H | ||
|
|
||
| #include "Ice/Config.h" |
There was a problem hiding this comment.
Simplified this file to align with other Xxx/Config.h in this repository.
| template<typename Key, typename Value, typename UpdateTag> | ||
| void Reader<Key, Value, UpdateTag>::waitForWriters(unsigned int count) const | ||
| { | ||
| _impl->waitForWriters(static_cast<int>(count)); |
There was a problem hiding this comment.
This static_cast is new, I have to add it because the signed/unsigned mismatch. There are a few others for other waitForXxx methods
scripts/DataStormUtil.py
Outdated
| props = Client.getProps(self, current) | ||
|
|
||
| # Default properties | ||
| props.update( |
There was a problem hiding this comment.
I added this default properties here, in the datastorm repository they were part of the DataStorm component class.
The component also provide a --multicast option that I haven't yet add here.
I would deal with this in a follow up PR.
| #ifndef DATASTORM_DATASTORM_H | ||
| #define DATASTORM_DATASTORM_H | ||
|
|
||
| #include "DataStorm/Config.h" |
There was a problem hiding this comment.
Should be "Config.h", "Node.h" etc.
| module DataStorm | ||
| { | ||
|
|
||
| /** |
There was a problem hiding this comment.
Would be nice to indent this file correctly.
|
|
||
| namespace DataStorm | ||
| { | ||
|
|
There was a problem hiding this comment.
We should clean-up all these extra empty lines in a follow-up PR.
The code comes straight from datastorm/3.8 branch with a few minor updates: