-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in Java OA constructor causing warning in finalizer #2955
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we should remove Java finalize which was deprecated in Java 9. For a future PR.
java/gradle/ice.gradle
Outdated
@@ -82,7 +82,7 @@ spotless { | |||
} | |||
|
|||
// Run spotlessApply before compiling Java code | |||
compileJava.dependsOn 'spotlessApply' | |||
// compileJava.dependsOn 'spotlessApply' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't be doing this. Otherwise we'll never know if the formatting is bad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then let's remove it.
Ensure _state is set to StateDestroyed otherwise we sometimes get a warning from the finalizer. Saw this warning when running tests in a slower container.