Add support for disposing communicator with "await using" #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
approved these changes
Feb 10, 2025
| onwarn: (warning, next) => { | ||
| // Ignore the "this is undefined" warning, let rollup silently rewrite it. | ||
| // This avoids warnings from the TypeScript polyfills for async disposable resources. | ||
| if (warning.code === "THIS_IS_UNDEFINED") return; |
There was a problem hiding this comment.
Just so I understand, what is "THIS_IS_UNDEFINED" referring to? Is it [Symbol.asyncDispose] because it's a Typescript thing?
Is this the standard way to add TypeScript features through JavaScript?
There was a problem hiding this comment.
No this is not related to Symbol.asyncDispose.
This is to avoid a rollup warning when we bundle the JavaScript code generated by TypeScript compiler.
TypeScript generates a polyfill for using await and the polyfill uses "this" in a top-level context which for ES6 is equivalent to undefined.
bernardnormier
approved these changes
Feb 10, 2025
externl
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3520