added blacklist precedence (blacklist trumps whitelist) #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<this proposed change makes more sense in
split
view>I read a warning in the docs that one could not use both blacklist and whitelist at the same time, ... This is because the blacklist processing overrides the previous whitelist processing. Assuming that blacklist processing should have precedence, that if the address is in both blacklist and whitelist, then the blacklist, as more restrictive, should win.
This proposed change performs the blacklist check first. Then, only if the address is not explicitly denied from the blacklist will the whitelist processing be performed.
There will be no impact to those implementations that have at most one {black|white}list.
I'm sure this pull-request isn't a big deal, as without wildcards most developers would not use both, ... but at least consider processing blacklist first, otherwise the blacklist processing completely undoes a whitelist denial.