Build with -D_DEFAULT_SOURCE along with -std=c11 #4635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On its own, -std=c11 hides POSIX and other extensions from C headers such as <stdlib.h> when building against glibc. This causes the posix_memalign probe to fail incorrectly with compilers that do not accept implicit function declarations. _DEFAULT_SOURCE is ignored by most non-GNU/Linux systems or not relevant in this context, so there is no separate check for adding it.
bluca
reviewed
Nov 29, 2023
bluca
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On its own,
-std=c11hides POSIX and other extensions from C headers such as<stdlib.h>when building against glibc. This causes theposix_memalignprobe to fail incorrectly with compilers that do not accept implicit function declarations._DEFAULT_SOURCEis ignored by most non-GNU/Linux systems or not relevant in this context, so there is no separate check for adding it.Related to: