Met à jour Sentry et corrige un avertissement #6623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- les fils d'Ariane n'aportent pas d'information supplémentaire, Sentry intercepte déjà les appels à Popen et les met dans le fil d'Ariane - la fonction add_breadcumb() était mal appelée et causait des avertissement de Sentry : "Sentry has identified the following problems for you to monitor: Discarded invalid value (3), expected an object"
Situphen
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sur une erreur de publication rapportée par Sentry, il y avait les avertissements suivants :
On utilise mal la fonction
add_breadcumb(). Mais en fait les appels àadd_breadcumb()(qui ajoutent des infos au fil d'Ariane) n'ajoutaient aucune information supplémentaire, puisque les appels à Popen sont déjà interceptés par Sentry, qui les ajoute directement au fil d'Ariane :Donc, j'ai tout simplement enlevé les appels à
add_breadcumb().J'en ai profité aussi pour mettre à jour
sentry-sdk. C'est un changement de version majeure, mais apparemment on n'a rien à changer.Contrôle qualité
La CI fonctionne et peut-être que je testerai sur le serveur de bêta.