feat: cosmos v50 upgrade #179

skosito · 2025-01-05T17:01:12Z

Follow up issues (I will open with more details after merging this PR)

refactor unit tests to reduce coupling between integration_tests.go and keeper tests (already done in cronos), this makes running some unit tests hard as integration_tests.go change keeper state and impact unit tests execution
uncomment test_upgrade and fix - this was already commented out before this PR, so probably not related
base fee in subscription related rpc methods is not contained in header events, should be refactored to use block and extract header from it

fix dependencies fix build upgrade protogen image Co-authored-by: mmsqe <[email protected]> wait for block properly fix py-lint fix test fix py-lint

coderabbitai · 2025-01-05T17:01:20Z

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

122 files out of 205 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

tests/integration_tests/network.py

tests/integration_tests/test_fee_history.py

tests/integration_tests/test_tracers.py

tests/integration_tests/test_upgrade.py

tests/integration_tests/test_websockets.py

app/ante/fee_checker.go

server/start.go

x/evm/keeper/msg_server.go

x/evm/keeper/state_transition.go

x/feemarket/keeper/abci.go

app/app.go

+	for _, m := range app.ModuleManager.Modules {
+		if moduleWithName, ok := m.(module.HasName); ok {
+			moduleName := moduleWithName.Name()
+			if appModule, ok := moduleWithName.(appmodule.AppModule); ok {
+				modules[moduleName] = appModule
+			}
+		}
+	}


cmd/ethermintd/root.go

x/evm/module.go

-func (am AppModule) BeginBlock(ctx sdk.Context, req abci.RequestBeginBlock) {
-	am.keeper.BeginBlock(ctx, req)
+func (am AppModule) BeginBlock(ctx context.Context) error {
+	return am.keeper.BeginBlock(sdk.UnwrapSDKContext(ctx))


x/evm/types/chain_config.go

x/evm/types/msg.go

x/feemarket/keeper/eip1559.go

-	if consParams != nil && consParams.Block.MaxGas > -1 {
-		gasLimit = big.NewInt(consParams.Block.MaxGas)
+	if consParams.Block == nil || consParams.Block.MaxGas <= -1 {
+		panic(fmt.Sprintf("get invalid consensus params: %s", consParams))


x/feemarket/keeper/params.go

+	store := k.storeService.OpenKVStore(ctx)
+	bz, err := store.Get(types.ParamsKey)
+	if err != nil {
+		panic(err)


x/feemarket/module.go

-func (am AppModule) BeginBlock(ctx sdk.Context, req abci.RequestBeginBlock) {
-	am.keeper.BeginBlock(ctx, req)
+func (am AppModule) BeginBlock(ctx context.Context) error {
+	return am.keeper.BeginBlock(sdk.UnwrapSDKContext(ctx))


x/feemarket/module.go

-	am.keeper.EndBlock(ctx, req)
-	return []abci.ValidatorUpdate{}
+func (am AppModule) EndBlock(ctx context.Context) error {
+	return am.keeper.EndBlock(sdk.UnwrapSDKContext(ctx))


skosito · 2025-01-20T13:44:43Z

encoding/config.go

+var InterfaceRegistry types.InterfaceRegistry
+
+func customGetSignerFn(path string) func(msg proto.Message) ([][]byte, error) {
+	return func(msg proto.Message) ([][]byte, error) {


in cronos fork from is changed to be bytes instead of string, but for now we can keep it string with this custom signer func

tests/integration_tests/test_fee_history.py

cmd/ethermintd/root.go

-	// add rosetta
-	rootCmd.AddCommand(rosettaCmd.RosettaCommand(encodingConfig.InterfaceRegistry, encodingConfig.Codec))
+	autoCliOpts := tempApp.AutoCliOpts()
+	initClientCtx, _ = clientcfg.ReadDefaultValuesFromDefaultClientConfig(initClientCtx)


tests/integration_tests/test_upgrade.py

gartnera · 2025-01-24T17:09:24Z

tests/integration_tests/test_upgrade.py

+#     )
+
+
+# def test_cosmovisor_upgrade(custom_ethermint: Ethermint):


can you just @pytest.mark.skip? should minimize the diff and future merge conflicts

Ah I was looking at the specific commit. If it was commented out before I think this is fine. We have upgrade test coverage on the node side.

yes it was commented out, i guess with same reasoning that we are testing upgrade anyways on node side, but will open the issue in any case to check this since it might uncover some hidden issue

gartnera

The cherry pick seems clean. Most of the extra diff comes from fixing the nix build and CI stuff.

skosito · 2025-01-24T19:01:10Z

The cherry pick seems clean. Most of the extra diff comes from fixing the nix build and CI stuff.

also because there were changes between our last cherry pick until this one that we didn't check in meantime, causing all kinds of issues with integration and unit tests

i will follow up on this in more details, but with future work, for this one i think it is fine

yihuang and others added 2 commits January 5, 2025 17:59

Problem: sdk 0.50 is not used

99eeed5

fix dependencies fix build upgrade protogen image Co-authored-by: mmsqe <[email protected]> wait for block properly fix py-lint fix test fix py-lint

fix imports

4f2e139

github-actions bot added C:Encoding C:Proto C:Types Type: Build C:CLI Type: Tests Type: Docs labels Jan 5, 2025

github-advanced-security bot found potential problems Jan 5, 2025

View reviewed changes

skosito added 15 commits January 5, 2025 19:09

go mod fixes

5f4e528

revert statedb changes

a6a6400

proto fixes

21c3df7

clesnup migrations

ac1b2bb

fixes

8436859

tmp comment code

42c9a4f

remove custom get signers

3503229

add signer annotation to msgethereumtx

7c6fc26

logs

1bc409a

remove validation

c84252a

add from field to msg

e3b712d

dont set empty msg.from field

8d8a426

remove from validation

43c2547

logs

5afebcf

fix custom get signers

b2860bd

skosito commented Jan 20, 2025

View reviewed changes

cleanup

9569c26

int tests fixes

5e95922

github-advanced-security bot found potential problems Jan 23, 2025

View reviewed changes

tests/integration_tests/test_fee_history.py Fixed Show fixed Hide fixed

skosito added 2 commits January 23, 2025 20:24

bump upload artifact to v4

01616b7

add autocli

f3ad28b

github-advanced-security bot found potential problems Jan 23, 2025

View reviewed changes

skosito added 13 commits January 23, 2025 23:53

more fixes

5ea92e7

revert

1494435

revert

521f9d5

typo

7abcfc2

revert go eth nix

f2105f7

log

e0cc7d0

fix state db add log

d023627

fixing remaining int tests

e7be8e3

uncomment upgrade integration test

011b25a

use vendorHash

0d9a712

fix go ver

3094aa3

fix vendor hash

eb9564b

test upgrade fix

d4fc2ec

github-advanced-security bot found potential problems Jan 24, 2025

View reviewed changes

tests/integration_tests/test_upgrade.py Fixed Show fixed Hide fixed

skosito added 5 commits January 24, 2025 14:06

add missing cmd

12d1012

comment back test upgrade

644e83a

py lints

9527906

py lint

aef63e6

gosec

b12523a

gartnera reviewed Jan 24, 2025

View reviewed changes

gartnera approved these changes Jan 24, 2025

View reviewed changes

lumtis approved these changes Jan 31, 2025

View reviewed changes

skosito merged commit 7ecd3d5 into main Jan 31, 2025
40 of 42 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: cosmos v50 upgrade #179

feat: cosmos v50 upgrade #179

skosito commented Jan 5, 2025 •

edited

Loading

coderabbitai bot commented Jan 5, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

skosito Jan 20, 2025

gartnera Jan 24, 2025

gartnera Jan 24, 2025

skosito Jan 24, 2025

gartnera left a comment

skosito commented Jan 24, 2025

		# )


		# def test_cosmovisor_upgrade(custom_ethermint: Ethermint):

feat: cosmos v50 upgrade #179

feat: cosmos v50 upgrade #179

Conversation

skosito commented Jan 5, 2025 • edited Loading

coderabbitai bot commented Jan 5, 2025 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

skosito Jan 20, 2025

Choose a reason for hiding this comment

gartnera Jan 24, 2025

Choose a reason for hiding this comment

gartnera Jan 24, 2025

Choose a reason for hiding this comment

skosito Jan 24, 2025

Choose a reason for hiding this comment

gartnera left a comment

Choose a reason for hiding this comment

skosito commented Jan 24, 2025

skosito commented Jan 5, 2025 •

edited

Loading

coderabbitai bot commented Jan 5, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)