- Decided not to implement the refactoring of parseHeader().

zetacomponents · Sep 3, 2009 · 46ee3f4 · 46ee3f4
1 parent fbb2c6a
commit 46ee3f4
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/review-1.7.txt b/review-1.7.txt
@@ -1,10 +1,14 @@
 ezcMailPartParser
 =================
 
-[ ] The function parseHeader() should be refactored. The new code has in 
+[x] The function parseHeader() should be refactored. The new code has in 
     the if() and elseif() case duplicated code that can easily be extracted
     into a new private method.
 
+    The code is too coupled and the private function will have 4-5 params.
+	It applies to only 4 lines of code. The solution which I tried actually
+	looks worse than what it is now.
+
 [x] The test in trunk/Mail/tests/composer_test.php should removed the
     added check for "charset=binary" as that is a bug in PHP (line 647ish)