Skip to content

Commit

Permalink
- Fixed some issues mentioned in the review.
Browse files Browse the repository at this point in the history
  • Loading branch information
as:ez.no committed Oct 29, 2007
1 parent 38012e4 commit 6e8d5b9
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
8 changes: 6 additions & 2 deletions review-1.2.txt
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
Review by Derick
================

[ ] I am not sure if the name for the new option constant for
[-] I am not sure if the name for the new option constant for
addUnorderedParameter() are good - the
ezcUrlConfiguration::AGGREGATE_ARGUMENTS one. Perhaps
MULTIPLE_ARRAY_ARGUMENTS would work? Or perhaps MULTIPLE_ARGUMENTS |
ARRAY_ARGUMENTS would be a viable alternative? I think the latter makes
most sense, but is slightly more to type.

I think the AGGREGATE_ARGUMENTS is better.

[ ] parseQueryString() will most likely have locale issues - needs
investigating.

Expand All @@ -21,5 +23,7 @@ Review by Derick
Additional review by kn
=======================

[ ] It would be nice to have some more class level documentation for
[X] It would be nice to have some more class level documentation for
ezcUrlTools, or at least mention it only provides static methods.

- Done.
6 changes: 6 additions & 0 deletions src/url_tools.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@
/**
* Class providing methods for URL parsing.
*
* Static methods contained in this class:
* - parseQueryString() - It implements the functionality of the PHP function
* parse_str(), but without converting dots to underscores in parameter names.
* - getCurrentUrl() - Returns the current URL as a string from the provided
* array (by default $_SERVER).
*
* @package Url
* @version //autogen//
*/
Expand Down

0 comments on commit 6e8d5b9

Please sign in to comment.