Error handling

zf-fr · Nov 23, 2013 · 153ef6d · 153ef6d
1 parent 3f356df
commit 153ef6d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 1.0.1
+
+* Better error handling
+
 # 1.0.0
 
 * Initial release
diff --git a/src/ZfrPaymill/Client/Listener/ErrorHandlerListener.php b/src/ZfrPaymill/Client/Listener/ErrorHandlerListener.php
@@ -97,9 +97,9 @@ public function handleError(Event $event)
         $command = $event['command'];
         $result  = $command->toArray();
 
-        $code = isset($result['data']['response_code']) ? $result['data']['response_code'] : 10001;
+        $code = isset($result['data']['response_code']) ? $result['data']['response_code'] : 20000;
 
-        if ($code >= 40000) {
+        if ($code !== 20000) {
             $exception = new TransactionErrorException($this->errorCodes[$code], $code);
             $exception->setRequest($command->getRequest());
             $exception->setResponse($command->getResponse());

diff --git a/tests/ZfrPaymillTest/Client/Listener/ErrorHandlerListenerTest.php b/tests/ZfrPaymillTest/Client/Listener/ErrorHandlerListenerTest.php
@@ -28,7 +28,7 @@ public function provider()
     {
         return array(
             array(
-                10000,
+                20000,
                 null,
                 null
             ),
-Original file line number
+Diff line change
@@ Expand Up / @@ -28,7 +28,7 @@ public function provider() @@
         {
             return array(
                 array(
-,
+,
                     null,
                     null
                 ),
@@ Expand Down @@