Skip to content

Commit

Permalink
Additional log entries when HTTP status 403 is received, for easier d…
Browse files Browse the repository at this point in the history
…etection

Signed-off-by: Andreas Maier <[email protected]>
  • Loading branch information
andy-maier committed Nov 24, 2023
1 parent 0acf968 commit 8d7808c
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docs/changes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ Released: not yet
* Added support for retrievel of firmware from an FTP server to the
Cpc/Console.single_step_install() methods. (issue #1342)

* Additional log entries when HTTP status 403 is received, for easier detection.

**Cleanup:**

**Known issues:**
Expand Down
9 changes: 9 additions & 0 deletions zhmcclient/_session.py
Original file line number Diff line number Diff line change
Expand Up @@ -1029,6 +1029,9 @@ def get(self, uri, resource=None, logon_required=True, renew_session=True):
if result.status_code == 403:
result_object = _result_object(result)
reason = result_object.get('reason', None)
message = result_object.get('message', None)
HMC_LOGGER.debug("Received HTTP status 403.%d on GET %s: %s",
reason, uri, message)

if reason in (4, 5):
# 403.4: No session ID was provided
Expand Down Expand Up @@ -1279,6 +1282,9 @@ def post(self, uri, resource=None, body=None, logon_required=True,
if result.status_code == 403:
result_object = _result_object(result)
reason = result_object.get('reason', None)
message = result_object.get('message', None)
HMC_LOGGER.debug("Received HTTP status 403.%d on GET %s: %s",
reason, uri, message)

if reason in (4, 5):
# 403.4: No session ID was provided
Expand Down Expand Up @@ -1378,6 +1384,9 @@ def delete(
if result.status_code == 403:
result_object = _result_object(result)
reason = result_object.get('reason', None)
message = result_object.get('message', None)
HMC_LOGGER.debug("Received HTTP status 403.%d on GET %s: %s",
reason, uri, message)

if reason in (4, 5):
# 403.4: No session ID was provided
Expand Down

0 comments on commit 8d7808c

Please sign in to comment.