Use instead of restoring side table for Loop #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouwfang
changed the title
ia0
reviewed
Dec 11, 2024
zhouwfang
force-pushed
the
use-side-table-for-loop
branch
from
2558c16 to
d1f028b
Compare
|
Will continue in google#705. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my Linux Docker container:
CoreMark results of this PR: 37.991516 (in 18.695s), 36.7287 (in 19.258s)
CoreMark results of google#690: 37.101162 (in 19.133s), 37.39716 (in 18.996s)
Look very similar. Not sure about
nordic.CoreMark results of
main: 28.791477 (in 18.09s), 28.814291 (in 17.734s)So there does seem some minor performance improvement with
delta_ipanddelta_stp.google#46