crypto.Certificate: case insensitive host name check #20545
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing host name with dns name from certificate should be case insensitive.
I found a few domains (from the cloudflare list of top domains) for which tls.Client fails to connect. Error is:
In its certificate this domains have dns names which are not strictly lower case. This is what checkHostName (called from verifyHostName) is comparing:
From RFC2818:
From RFC2459:
Domain certificate can be inspected with something like:
Testing with:
$ zig run main.zig -- truist.com