Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting PGID in std.process.Child.spawn #20556

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Allow setting PGID in std.process.Child.spawn #20556

merged 2 commits into from
Jul 22, 2024

Conversation

McSinyx
Copy link
Contributor

@McSinyx McSinyx commented Jul 9, 2024

std.process.Child is a nice abstraction, and it could be nicer if it can set the process group ID, which is useful if we want to kill that process and all its descendants.

Please let me know if backward compatibility in Child.kill's signature should be broken, or a killpg function should be added instead.

Slightly relevant: should Child.kill let caller choose the signal?

@McSinyx McSinyx marked this pull request as draft July 9, 2024 13:44
@McSinyx McSinyx marked this pull request as draft July 9, 2024 13:44
@McSinyx McSinyx marked this pull request as draft July 9, 2024 13:44
@McSinyx McSinyx marked this pull request as ready for review July 9, 2024 15:46
lib/std/posix.zig Outdated Show resolved Hide resolved
Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge. Would you mind rebasing to solve the conflicts?

@andrewrk
Copy link
Member

Thanks!

@andrewrk andrewrk enabled auto-merge July 21, 2024 08:12
@McSinyx
Copy link
Contributor Author

McSinyx commented Jul 21, 2024

Awesome, thanks!

auto-merge was automatically disabled July 21, 2024 10:31

Head branch was pushed to by a user without write access

@andrewrk
Copy link
Member

Please rebase one more time; we had failures on master branch. I would do it for you but you have unchecked "allow edits from maintainers".

@McSinyx
Copy link
Contributor Author

McSinyx commented Jul 22, 2024

Thanks, although the std-docs build for macOS on amd64 is failing mysteriously (some cache file not found), despite the same job runs fine on the base commit 179a6e6 on master. I will enable the allow edits thingie and defer it to you maintainers who know better of what's going (wr)on(g).

@andrewrk
Copy link
Member

Sorry for the trouble, I will take it from here.

@andrewrk andrewrk merged commit eac7fd4 into ziglang:master Jul 22, 2024
9 of 10 checks passed
@McSinyx
Copy link
Contributor Author

McSinyx commented Jul 23, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants