-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting PGID in std.process.Child.spawn #20556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge. Would you mind rebasing to solve the conflicts?
Thanks! |
Awesome, thanks! |
Head branch was pushed to by a user without write access
Please rebase one more time; we had failures on master branch. I would do it for you but you have unchecked "allow edits from maintainers". |
Thanks, although the std-docs build for macOS on amd64 is failing mysteriously (some cache file not found), despite the same job runs fine on the base commit 179a6e6 on master. I will enable the allow edits thingie and defer it to you maintainers who know better of what's going (wr)on(g). |
Sorry for the trouble, I will take it from here. |
Thanks!
|
std.process.Child is a nice abstraction, and it could be nicer if it can set the process group ID, which is useful if we want to kill that process and all its descendants.
Please let me know if backward compatibility in Child.kill's signature should be broken, or a
killpg
function should be added instead.Slightly relevant: should Child.kill let caller choose the signal?