std.Target: Assorted corrections, plus cleanup around ELF/COFF machine types
#21020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
force-pushed
the
target-fixes
branch
5 times, most recently
from
baa28d6 to
80f771d
Compare
|
Unrelated hang on |
…e OSs. Reference for versions: https://developer.apple.com/support/xcode
AIX does not have a stable syscall interface; libc is required.
The arc tag means ARCv2.
EM_MIPS_RS3_LE is obsolete; all mips targets just use EM_MIPS. Also, fun fact: EM_MIPS_RS3_LE is actually big endian!
…e(). All of these were mapping to types that are little endian. In fact, I can find no evidence that either Windows or UEFI have ever been used on big endian systems.
It's entirely unclear whether this should map to POWERPC or POWERPCFP, and as I can find no evidence of people producing PE files for PowerPC since Windows NT, let's just not make a likely-wrong guess. We can revisit this if the need ever actually arises.
This does the same thing as std.Target.Cpu.Arch.toCoffMachine(). Just use that.
This enables them to give more correct results. Contributes to ziglang#20771.
|
Thanks! |
alexrp
added a commit
to alexrp/zig
that referenced
this pull request
Aug 19, 2024
These are fundamentally incapable of producing accurate information for reasons I've laid out in ziglang#20771. Since our only use of these functions is to check that object files have the correct machine type, and since ziglang#21020 made `std.Target.to{Coff,Elf}Machine()` more accurate, just switch these checks over to that and compare the machine type tags instead. Closes ziglang#20771.
alexrp
added a commit
to alexrp/zig
that referenced
this pull request
Aug 23, 2024
These are fundamentally incapable of producing accurate information for reasons I've laid out in ziglang#20771. Since our only use of these functions is to check that object files have the correct machine type, and since ziglang#21020 made `std.Target.to{Coff,Elf}Machine()` more accurate, just switch these checks over to that and compare the machine type tags instead. Closes ziglang#20771.
alexrp
added a commit
to alexrp/zig
that referenced
this pull request
Aug 23, 2024
These are fundamentally incapable of producing accurate information for reasons I've laid out in ziglang#20771. Since our only use of these functions is to check that object files have the correct machine type, and since ziglang#21020 made `std.Target.to{Coff,Elf}Machine()` more accurate, just switch these checks over to that and compare the machine type tags instead. Closes ziglang#20771.
alexrp
added a commit
to alexrp/zig
that referenced
this pull request
Aug 23, 2024
These are fundamentally incapable of producing accurate information for reasons I've laid out in ziglang#20771. Since our only use of these functions is to check that object files have the correct machine type, and since ziglang#21020 made `std.Target.to{Coff,Elf}Machine()` more accurate, just switch these checks over to that and compare the machine type tags instead. Closes ziglang#20771.
richerfu
pushed a commit
to richerfu/zig
that referenced
this pull request
Oct 28, 2024
These are fundamentally incapable of producing accurate information for reasons I've laid out in ziglang#20771. Since our only use of these functions is to check that object files have the correct machine type, and since ziglang#21020 made `std.Target.to{Coff,Elf}Machine()` more accurate, just switch these checks over to that and compare the machine type tags instead. Closes ziglang#20771.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.