Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Re-enable mips(el)-linux(-musl) tests. #21053

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

alexrp
Copy link
Member

@alexrp alexrp commented Aug 12, 2024

Andrew mentioned that LLVM's MIPS backend has O(N^2) codegen. Just want to take this for a spin and see if that remains the case.

@linusg
Copy link
Contributor

linusg commented Aug 12, 2024

Unfortunately that's still the case, at least I observe excessive build times when building Kiesel for mips-linux-musl (~100-120s vs ~30s for mips64-linux-musl and x86_64-linux-musl).

There's #18872 (and dddddcf) for RISC-V, we might want to have a separate issue for MIPS depending on the outcome of this PR.

@alexrp
Copy link
Member Author

alexrp commented Aug 12, 2024

Hmmmmmm... there's enough fluctuation in run times across PRs that it's a bit hard to tell how bad this is. Some of my other PRs have run times that look almost identical to this, but then others are anywhere between 20-40 minutes faster. Presumably it completely depends on how busy CI is at any given time, and it seems to be quite busy right now. That said, based on my local testing, I think it's fair to assume that this will at least add 20 minutes to run times.

Totally understand if this is not acceptable; if so, I can just separate out the two commits that disable failing tests and PR those independently.

@andrewrk
Copy link
Member

It's most noticeable when you test locally with zig build test-std.

But, OK, let's try it for now. Maybe an option to skip those can be added which can be useful for local testing.

@andrewrk andrewrk merged commit 0b5ea2b into ziglang:master Aug 13, 2024
10 checks passed
@alexrp
Copy link
Member Author

alexrp commented Aug 13, 2024

That seems like a good idea. I would even say it'd be fine for these slower targets to be off by default, with CI explicitly opting into testing them.

@alexrp alexrp deleted the mips-tests branch August 13, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants