Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loongarch: add missing getcontext #21062

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

yxd-ym
Copy link
Contributor

@yxd-ym yxd-ym commented Aug 13, 2024

to make it work for zig-bootstrap for loongarch64-linux-musl

@andrewrk
Copy link
Member

TODO? come on... how about actually doing it.

@alexrp
Copy link
Member

alexrp commented Aug 13, 2024

Note that it was likely copied from the riscv arch bits file which also has it as a TODO. 🙂 (riscv and loongarch share like 90% of Linux ABI details.) Even defining it to {} is actually quite a bit better than nothing because the standard library will not build at all if it isn't defined. Defining it is also surprisingly non-trivial because there are glibc ABI compatibility issues to consider.

So fwiw, I think it's fine to merge this as-is. And in any case, one of my local branches has ongoing work to thoroughly fill out the arch bits files for all Linux architectures, so I'll get to it eventually even if this PR doesn't.

@andrewrk
Copy link
Member

OK

@andrewrk andrewrk merged commit 76f0626 into ziglang:master Aug 13, 2024
10 checks passed
@yxd-ym yxd-ym deleted the getcontext branch August 14, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants