-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support running LLVM backend in a separate thread #21068
base: master
Are you sure you want to change the base?
Conversation
Backends should never be calling |
c0adbb9
to
61b53d0
Compare
The only caller of |
What makes it "hacky" and what would a non "hacky" fix do differently? |
Checking the value every time at the end of |
61b53d0
to
f9a38de
Compare
f9a38de
to
bc9cc55
Compare
bc9cc55
to
6f9c4ee
Compare
Closes #20635
@jacobly0
Most changes are quite straightforward, I did however have to move some Compilation mutex locking from Compilation.zig into PerThread.zig in order to fix a race condition on Zcu.import_tables. This seemed like the most reasonable solution as it's accessed all over the place in Sema.zig, but maybe it goes against some overarching locking strategy?